Re: [PATCH] Support splitting SOURCE in multiple rmk files

[Robert Millan]

On Wed, Jun 24, 2009 at 08:13:35PM +0800, Bean wrote:
> >> +bin_UTILITIES += grub-mkelfimage
> >> +grub_mkelfimage_SOURCES = util/resolve.c
> >> +
> >>  pkglib_MODULES += cpuid.mod
> >>  cpuid_mod_SOURCES = commands/i386/cpuid.c
> >>  cpuid_mod_CFLAGS = $(COMMON_CFLAGS)
> >
> > This looks very confusing.  If what is actually doing is append a new
> > string to the grub_mkelfimage_SOURCES variable, why not with "+=" ?
> >
> > "=" means override the previous value.
> 
> Hi,
> 
> You can use = or +=, actually the macro is used by genmk.rb to
> generate the rules, it's not used by Makefile itself, so no problem
> overriding it.

Yes, but using = to generate a rule that actually means += is very confusing.
Please don't do that.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."