Re: [PATCH] search -d|--disk

[Pavel Roskin]

On Tue, 2009-06-23 at 01:48 +0200, Robert Millan wrote:

> This patch adds an option to the search command to restrict the search of
> a file to a given disk.  It will then probe for the file in each of its
> partitions, but not in other disks.

First of all, it would be great is all proposals to add more code come
with a possible use case.  We are approaching the point when grub with
all modules would become too big to some boot partitions.

"VAR" should be "DISK".

"in this disk" should be "on this disk" (disclaimer: English is not my
native language).

"and its partitions" seems excessive to me.  If the disk has partitions,
of course that where we would look.

The implementation is not working:

sh:grub> search -d foo -l /
 hd0,3

I hope that it would be possible to specify a partition for the disk, so
that we easily can look e.g. for a partition with label "/" on a disk
with a partition containing "/boot/grub/grub.cfg".

-- 
Regards,
Pavel Roskin