[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] move grub_stop() (Re: [PATCH] i386-qemu port)
|
From: |
Pavel Roskin |
|
Subject: |
Re: [PATCH] move grub_stop() (Re: [PATCH] i386-qemu port) |
|
Date: |
Mon, 22 Jun 2009 12:16:35 -0400 |
On Mon, 2009-06-22 at 12:10 +0200, Robert Millan wrote:
> My aim was to move this to C code so it can be shared between i386-qemu
> and i386-coreboot. However, this code will be the same on other i386
> ports, but we don't yet have a generic .S file for i386 code.
>
> How about kern/i386/misc.S ?
Fine with me. We shouldn't switch to inferior C code just because we
don't have a shared .S file.
> This seems to be the current behaviour, unless I missed something.
OK, never mind. I should have done that analysis before bringing up the
issue.
Anyway, I think grub_halt() should be renamed to grub_poweroff() to be
more explicit about its goal.
--
Regards,
Pavel Roskin
[PATCH] move grub_stop() (Re: [PATCH] i386-qemu port), Robert Millan, 2009/06/21
Re: [PATCH] i386-qemu port, Pavel Roskin, 2009/06/21
[PATCH] rename kernel.elf to kernel.img (Re: [PATCH] i386-qemu port), Robert Millan, 2009/06/21
[PATCH] swap real_to_prot() and prot_to_real() (Re: [PATCH] i386-qemu port), Robert Millan, 2009/06/21