Re: [PATCH] i386-qemu port

[Robert Millan]

On Sun, Jun 21, 2009 at 09:50:25PM -0400, Pavel Roskin wrote:
> On Sun, 2009-06-21 at 22:22 +0200, Robert Millan wrote:
> > New patch, after a bunch of misc cleanup, turning hardcoded numbers into
> > macros, improving comments, etc.
> 
> kernel_img_FORMAT is defined but never used.

It's used by the build system, see:

genmk.rb:       $(OBJCOPY) -O $(#{prefix}_FORMAT) --strip-unneeded -R .note -R 
.comment -R .note.gnu.build-id $< $@

> GRUB_MEMORY_MACHINE_LINK_ADDR doesn't need to be conditional, it's the
> same for coreboot and qemu.

Ok.

> Renaming kernel.elf to kernel.img could be done separately.  Since it's
> a trivial patch, it can be committed without review provided that is
> compiles.

Committed already.

> Please don't add trailing whitespace.

Fixed.

> Here's my fix for compile warnings and errors.  Please incorporate.

Merged, thanks.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."