grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] rename kernel.elf to kernel.img (Re: [PATCH] i386-qemu port)


From: Pavel Roskin
Subject: Re: [PATCH] rename kernel.elf to kernel.img (Re: [PATCH] i386-qemu port)
Date: Sun, 21 Jun 2009 22:20:04 -0400

On Sun, 2009-06-21 at 21:19 +0200, Robert Millan wrote:
> If you check my earlier patch, you'll see i386-qemu.rmk is just a stub
> that includes i386-coreboot.rmk.  This is to reduce code duplication
> (untill we have a more flexible build system).
> 
> This patch renames kernel.elf to kernel.img in ELF platforms, so that
> more variables / etc can be shared with non-ELF ones.

No objections as long as it compiles without warnings.  Sharing more
code is a good thing.

By please note that I had to add kernel_elf_ASFLAGS in
i386-ieee1275.rmk, or with would not compile on x86_64, as some compiler
invocations would miss -m32.  So you patch will need to be adjusted for
that.

-- 
Regards,
Pavel Roskin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]