grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Remove root drive support


From: Vladimir 'phcoder' Serbinenko
Subject: Re: [PATCH] Remove root drive support
Date: Thu, 18 Jun 2009 18:57:00 +0200



On Tue, Jun 16, 2009 at 8:09 PM, Pavel Roskin <address@hidden> wrote:
On Tue, 2009-06-16 at 12:30 +0200, Vladimir 'phcoder' Serbinenko wrote:

>         I think we could implement partition addressing by a contained
>         filename.
>         As long as GRUB can read the filesystem at all, it should be
>         able to
>         read filenames.
> Otherwise the filesystem needs improvement

The great thing is that we don't even need the ability to read
directories, so we can support PXE and other very limited filesystems.

>          Then we would specify grub_prefix as
>
>         (FILE=/boot/grub/FSID)/boot/grub
>
>         FSID could be a random string or is could be the filesystem
>         UUID as read
>         by the OS.  grub-setup would create such file and hardcode the
>         corresponding grub_prefix into core.img.
> Good idea. Do you want to implement it?

The kernel side was easy.  The patch is attached.  Actually, I'm not
sure I got the disk ID right.  I copied it from fs_uuid.c, but I need to
recheck it.
Update copyright year. I suggest putting new id in grub_disk_dev_id to the end. You also forgot to add it to grub-emu. Under qemu it worked well except that it wasn't autoloaded but I looked and seen that we have no module autoloading for device drivers, perhaps because some of them don't coexist well. Except issues mentioned patch looks fine and I think you can commit it even if we don't have userspace part yet

We still need the userspace changes.

--
Regards,
Pavel Roskin

_______________________________________________
Grub-devel mailing list
address@hidden
http://lists.gnu.org/mailman/listinfo/grub-devel




--
Regards
Vladimir 'phcoder' Serbinenko

reply via email to

[Prev in Thread] Current Thread [Next in Thread]