[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 7/18] Don't clobber ebx/rbx in inline assembly when compiling
|
From: |
Pavel Roskin |
|
Subject: |
Re: [PATCH 7/18] Don't clobber ebx/rbx in inline assembly when compiling with Apple's CC |
|
Date: |
Mon, 15 Jun 2009 21:32:23 -0400 |
On Sat, 2009-05-30 at 16:49 +0200, Vladimir 'phcoder' Serbinenko wrote:
> +#ifdef APPLE_CC
> __asm__ __volatile__ ("xorl %%eax, %%eax\n\t"
> - "cpuid":::"%rax", "%rbx", "%rcx", "%rdx");
Why do we need preprocessor conditionals here? What are we winning? I
think it's more important to have reusable, well tested and well
maintained code that to save two assembly instructions.
--
Regards,
Pavel Roskin
- Re: [PATCH 7/18] Don't clobber ebx/rbx in inline assembly when compiling with Apple's CC,
Pavel Roskin <=