Re: [PATCH] probe command

[Vladimir 'phcoder' Serbinenko]

Comitted

On Wed, Jun 10, 2009 at 10:11 AM, Vladimir 'phcoder'
Serbinenko<address@hidden> wrote:
> On Tue, Jun 9, 2009 at 11:48 PM, Pavel Roskin<address@hidden> wrote:
>> On Tue, 2009-06-09 at 22:55 +0200, Vladimir 'phcoder' Serbinenko wrote:
>>
>>> > --target=partmap doesn't work on whole disks.
>>> It was the intent. I'm norking on nested partitions and consider the
>>> following situation:
>>> hd0 is subdivided by pc partmap into
>>> hd0,1 - linux
>>> hd0,2 - solaris which is subdivided by sun partmap into
>>> hd0,2,1 - root
>>> hd0,2,2 - swap
>>> Then
>>> probe -p hd0 gives "none"
>>> probe -p hd0,2 gives "pc"
>>> probe -p hd0,2,2 gives "sun"
>>> another possibility would be
>>> probe -p hd0 gives "pc"
>>> probe -p hd0,2 gives "sun"
>>> probe -p hd0,2,2 gives "none"
>>> I don't have strong preference for one or other option but it can't
>>> say "pc" on both hd0 and hd0,1
>>
>> I think it the concept is not obvious to the user, maybe we could omit
>> that functionality?  Are you going to use it anywhere?
> The idea was to give the scriptwriters more possibilities for
> autoconfig. There is normally no reason for an end user to use this
> functionality at all but it may be useful in writing automated scripts
> for usage on e.g. rescue CD
>>
>>> P.S. could you improve & commit your target libc patch?
>>
>> I'm looking at it now, but it will take some time.  I've just noticed
>> that I didn't post another patch that is required for correct
>> implementation (AC_CHECK_FUNCS doesn't work if the target headers are
>> missing).  Also, I want to eliminate GRUB_SOURCE, at least from the
>> configuration scripts.
>>
>> --
>> Regards,
>> Pavel Roskin
>>
>>
>> _______________________________________________
>> Grub-devel mailing list
>> address@hidden
>> http://lists.gnu.org/mailman/listinfo/grub-devel
>>
>
>
>
> --
> Regards
> Vladimir 'phcoder' Serbinenko
>



-- 
Regards
Vladimir 'phcoder' Serbinenko