Re: [PATCH] savedefault

[Vladimir 'phcoder' Serbinenko]

Hello

On Mon, Jun 8, 2009 at 9:37 AM, Bean<address@hidden> wrote:
> On Sun, Jun 7, 2009 at 10:51 PM, Vladimir 'phcoder'
> Serbinenko<address@hidden> wrote:
>> Hello. Welcome back
>>
>> On Sun, Jun 7, 2009 at 11:35 AM, Bean<address@hidden> wrote:
>>> Hi,
>>>
>>> Actually, I'm thinking about a more generic method to implement this
>>> feature with events. The menu viewer fire events at certain
>>> circumstance, and we can configure the commands to execute. For
>>> example, we could have a menu.select event fire when a menu item is
>>> selected, and use something like this in grub.cfg:
>>>
>>> event add menu.select save_env saved_entry
>>>
>>> Command "save_env saved_entry" would be run automatically, no need to
>>> patch up the menu items.
>> Often user doesn't want some entries to be saved as default. E.g.
>> "single user" entries. I know that it's easy to revert to other method
>> but if nearly everyone does your work will be effort for nothing
>
> Hi,
>
> Now the menuitem support attributes, perhaps we could utilize it to
> store parameters for the event handler, for example, "save/nosave" for
> savedefault, "lock/unlock" for password, etc.
>
Difficult to say whether such addition would be useful. I feel like
it's over-engineering. I may be wrong however. Fell free to expose
what you have in your head about this idea.
Meanwhile could we merge my patch? We can add fancy handlers later
>>>
>>> One advantage with the event model is that it can handle password at
>>> the same time, for example, we could write something like this:
>>>
>>> event add menu.select_check password
>>> event add menu.commandline_check password
>>>
>>> password command is run when user tries to select the menu item or
>>> enter command line.
>>>
>>> On Mon, Jun 1, 2009 at 6:48 PM, Vladimir 'phcoder'
>>> Serbinenko<address@hidden> wrote:
>>>> Hello. Here is a long-awaited savedefault patch. Works correctly only
>>>> if my scripting fix is applied
>>>>
>>>> --
>>>> Regards
>>>> Vladimir 'phcoder' Serbinenko
>>>>
>>>> _______________________________________________
>>>> Grub-devel mailing list
>>>> address@hidden
>>>> http://lists.gnu.org/mailman/listinfo/grub-devel
>>>>
>>>>
>>>
>>>
>>>
>>> --
>>> Bean
>>>
>>>
>>> _______________________________________________
>>> Grub-devel mailing list
>>> address@hidden
>>> http://lists.gnu.org/mailman/listinfo/grub-devel
>>>
>>
>>
>>
>> --
>> Regards
>> Vladimir 'phcoder' Serbinenko
>>
>>
>> _______________________________________________
>> Grub-devel mailing list
>> address@hidden
>> http://lists.gnu.org/mailman/listinfo/grub-devel
>>
>
>
>
> --
> Bean
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>



-- 
Regards
Vladimir 'phcoder' Serbinenko