Re: [PATCH] Link usb controller struct only when initialised

[Vladimir 'phcoder' Serbinenko]

Commited with small stylistic change: comments start with an uppercase
letter and end with 2 spaces

On Sun, Jun 7, 2009 at 8:37 PM, Oliver Henshaw<address@hidden> wrote:
> When controller initialisation is aborted in grub_uhci_pci_iter
> (grub_ohci_pci_iter) control
> jumps to "fail:", where any allocated memory is freed. However, the
> struct grub_uhci *u
> (struct grub_ohci *o) for that controller remains linked to the list
> of UHCI (OHCI)
> controllers. This causes problems later, when grub iterates over
> controllers to initialise
> their ports.
>
> The solution is to link only when the usb controller is successfully
> initialised, and just
> before returning from the function.
>
> This patch is tested with real hardware and with qemu and the rescue image.
>
>
> Thanks,
> Oliver
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
>



-- 
Regards
Vladimir 'phcoder' Serbinenko