grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] drivemap fixes


From: Pavel Roskin
Subject: Re: [PATCH] drivemap fixes
Date: Sun, 07 Jun 2009 22:10:41 -0400

On Fri, 2009-06-05 at 16:27 +0200, Vladimir 'phcoder' Serbinenko wrote:
> Hello. As suggested by Javier Martín I move this to a new thread. This
> patch fixes some problems with determining bios number of a disk.
> biosnum is in boot.mod because it's where it will cause the least of
> possible core.img increase (3 of 5 loaders on pc need biosnum).
> Thisforced to move boot.mod to platform-specific files but this
> inflexibility of build system is a subject for another patch

I'll appreciate if you also provide ChangeLog.  Also, it would be great
if you specify, which exactly problems the patch fixes.

As for the fixes to the handler, I think they should be submitted
separately.  Please avoid non-words like "postamble".  Comments would be
nice.  I would try to avoid having two long calls if possible.

-- 
Regards,
Pavel Roskin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]