grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] add drivemap support to 30_os-prober.in and use UUIDs


From: Pavel Roskin
Subject: Re: [PATCH] add drivemap support to 30_os-prober.in and use UUIDs
Date: Sun, 07 Jun 2009 11:55:52 -0400

On Sun, 2009-06-07 at 17:37 +0200, Felix Zielcke wrote:
> Attached patch uses `prepare_grub_to_access_device' to set the root in
> the generated entrys.
> And it adds drivemap to the chainload ones, if root isn't (hd0).
> 
> The Debian grub-installer adds map only with Dos and Windows, should I
> do the same or is it okay to do it for all?

Perhaps it would be better to avoid it when it's not needed.  But it may
be tricky to determine what bootloader we are using.

Let's do it always and eliminate the cases where it's harmful or
definitely useless.

> -# update-grub helper script.
> +# grub-mkconfig helper script.
> Does this needs to be mentioned in ChangeLog?

The standard says:

'When you change just comments or doc strings, it is enough to write
an entry for the file, without mentioning the functions.  Just "Doc
fixes" is enough for the change log.'

-- 
Regards,
Pavel Roskin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]