Re: status grub2 port of grub-legasy map command

[Vladimir 'phcoder' Serbinenko]

On Mon, Jun 1, 2009 at 11:45 PM, Vladimir 'phcoder'
Serbinenko<address@hidden> wrote:
> 2009/6/1 Javier Martín <address@hidden>:
>> El lun, 01-06-2009 a las 11:53 +0200, Vladimir 'phcoder' Serbinenko
>> escribió:
>>> > Hmm... from those docs, and accepting that we ignore TSRs, we need to
>>> > save %ah and %dl at handler entry, then check the saved %ah at exit,
>>> > like the old handler from GRUB Legacy did - by the way, when writing the
>>> > new handler, I asked what that code did and noone was able to tell me ¬¬
>>> I've the check before calling original handler. Let's hope it makes
>>> code more readable.
>> Personally, I don't think the readability gain is so big to offset the
>> code size increase, but this is just a single opinion.
> I personally don't really care how to do it. But for economy of effort
> I prefer to take what I already have :) But if you insist I can change
> it
I found a way to make it smaller. (a trick with jump). See the attached patch.
I also solved the %dl problem (at least partially). I've put biosnum
routine to boot.mod because 3 of 5 loaders need it on pc so I think
boot.mod is better then a separate module. In the same time it doesn't
go to kernel. This move forces to put boot.mod to platform-specific
files but this inflexibility of build system is a subject for another
patch
>> --
>> -- Lazy, Oblivious, Recurrent Disaster -- Habbit
>>
>> _______________________________________________
>> Grub-devel mailing list
>> address@hidden
>> http://lists.gnu.org/mailman/listinfo/grub-devel
>>
>>
>
>
>
> --
> Regards
> Vladimir 'phcoder' Serbinenko
>



-- 
Regards
Vladimir 'phcoder' Serbinenko

drivemap.diff
Description: Text Data