grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] add true and false commands


From: Felix Zielcke
Subject: Re: [PATCH] add true and false commands
Date: Fri, 05 Jun 2009 10:47:03 +0200

Am Donnerstag, den 04.06.2009, 10:21 +0200 schrieb Marco Gerards:
> Felix Zielcke <address@hidden> writes:
> 
> > Am Montag, den 01.06.2009, 16:24 +0200 schrieb Vladimir 'phcoder'
> > Serbinenko:
> >> However convention for
> >> creating false is:
> >>   return grub_error (GRUB_ERR_TEST_FAILURE, "false");
> >> and not
> >>   return 1;
> >
> > Ok changed it. If everyone is fine with placing this in normal/main.c, I
> > commit it.
> 
> Unless it is essential to do so, please do not place it in
> normal/main.c.
> 

would normal/misc.c be okay or maybe a new file normal/true.c?
I just don't think it's worth to create a new module for these 2 very
little commands.
-- 
Felix Zielcke





reply via email to

[Prev in Thread] Current Thread [Next in Thread]