Re: [PATCH] support of hfsx ( case comparaison )

[Vladimir 'phcoder' Serbinenko]

> Well, thanks for taking time to review :)
You're welcome
>
> Just for my own curiosity, isn't the inlining of function automatic with
> gcc and recent compiler ?
It is. However if you want to be sure better to say it explicitely
>
>> @@ -218,6 +228,7 @@ struct grub_hfsplus_data
>>    /* This is the offset into the physical disk for an embedded HFS+
>>       filesystem (one inside a plain HFS wrapper).  */
>>    int embedded_offset;
>> +  int catalog_cmp_key;
>> Where is this used? I see that you set it to a value but don't see you
>> actually using it
>
> in grub_hfsplus_is_case_insentive, in the case of GRUB_HFSPLUSX_MAGIC :
>
> +      case GRUB_HFSPLUSX_MAGIC:
> +        return data->catalog_cmp_key == GRUB_HFSPLUSX_CASEFOLDING;
>
Ok. I see a two last problems with your patch:
+  grub_uint32_t clump_size;  // ignored
We use /* Ignored.  */ style of comments
@@ -3106,7 +3112,6 @@
        (freetype_libs): Likewise.

        * util/grub-mkfont.c: New file.
-
Bogus hunk
>
> --
> Michael Scherer
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
>



-- 
Regards
Vladimir 'phcoder' Serbinenko