Re: [PATCH] add true and false commands

[Vladimir 'phcoder' Serbinenko]

On Mon, Jun 1, 2009 at 4:18 PM, Felix Zielcke <address@hidden> wrote:
> Am Samstag, den 30.05.2009, 17:14 +0200 schrieb Vladimir 'phcoder'
> Serbinenko:
>> On Wed, May 27, 2009 at 2:16 PM, Felix Zielcke <address@hidden> wrote:
>> > Hi,
>> >
>> > here's a simple patch which adds a `true' and a `false' command.
>> > `true' is actually needed by the compatibility code generated by
>> > grub-mkconfig for the terminal.
>> As far as I understand they are useful only in normal mode. Perhaps
>> putting them into normal.mod or sh.mod would make more sense?
>
> Ok here's a new patch which places them into normal.mod.
> Does a `false' command actually make sense in grub?
It does since we make bash-similar scripting. However convention for
creating false is:
  return grub_error (GRUB_ERR_TEST_FAILURE, "false");
and not
  return 1;
> --
> Felix Zielcke
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
>



-- 
Regards
Vladimir 'phcoder' Serbinenko