Re: [PATCH] Use common linker script for all i386-pc systems

[Vladimir 'phcoder' Serbinenko]

Hello.

On Sun, May 17, 2009 at 7:33 AM, Pavel Roskin <address@hidden> wrote:
> This allows us to remove checks for the linker symbols for the beginning
> and the end of the .bss section.  Instead, we use the names from the
> linker script.  Another benefit is a better unification of the build
> system.
>
I have nothing against this patch. However it modifies similar parts
of build system as my Apple's CC patch. Could we perhaps get my patch
in first? Also Apple's LD has no support for  linker scripts so
unification will not be complete.
> diff --git a/conf/i386-pc.lds b/conf/i386-pc.lds
> new file mode 100644
> index 0000000..a41cac7
> --- /dev/null
> +++ b/conf/i386-pc.lds
> @@ -0,0 +1,53 @@
> +/* Linker script to create grub .img files on Cygwin.  */
This comment is out of sync
>  VARIABLE(grub_end_addr)
> -       .long   END_SYMBOL
> +       .long   __bss_end__
This variable isn't used at all. In my Apple's CC patch I just remove it

-- 
Regards
Vladimir 'phcoder' Serbinenko