grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: can't compile r220 because of setjmp.S


From: Bean
Subject: Re: can't compile r220 because of setjmp.S
Date: Sun, 17 May 2009 03:49:26 +0800

Hi,

Oh, sorry about the setjmp breakage. BTW, I've written a wiki page on
lua script engine:

http://grub.enbug.org/LUASupport

On Sun, May 17, 2009 at 1:32 AM, Felix Zielcke <address@hidden> wrote:
> Am Samstag, den 16.05.2009, 19:27 +0200 schrieb Vladimir 'phcoder'
> Serbinenko:
>> 2009/5/16 Javier Martín <address@hidden>:
>> > El sáb, 16-05-2009 a las 19:22 +0200, Felix Zielcke escribió:
>> >> Am Samstag, den 16.05.2009, 18:52 +0200 schrieb Felix Zielcke:
>> >>
>> >> > As said on IRC, it seems like the -m32 was missing there, even though it
>> >> > should be set through the COMMON_CSFLAGS in i386-pc.rmk.
>> >> > But that did the trick in i386.rmk:
>> >> >
>> >> > -setjmp_mod_CFLAGS = $(COMMON_CFLAGS)
>> >> > +setjmp_mod_ASFLAGS = $(COMMON_ASFLAGS)
>> >>
>> >> Commited this change as Acked-by Vladimir on IRC.
>> > You only changed it in i386. Given that a .S file is always "compiled"
>> > by the assembler, shouldn't the change be applied to all other platforms
>> > too?
>> >
>> True. I didn't see it was the same mistake in other arches as well. Nice 
>> catch
>
> Changed now for the other arches too.
> --
> Felix Zielcke
>
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>



-- 
Bean




reply via email to

[Prev in Thread] Current Thread [Next in Thread]