grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: status grub2 port of grub-legasy map command


From: Pavel Roskin
Subject: Re: status grub2 port of grub-legasy map command
Date: Sun, 03 May 2009 15:45:38 -0400

On Sun, 2009-05-03 at 11:17 +0200, Vladimir 'phcoder' Serbinenko wrote:

>         I would suggest, however, that the return type of
>         grub_mmap_malign_and_register be changed to void* from char*,
>         just like
>         the return type from malloc, because it's the meaningful data
>         type to
>         indicate a pointer to generic memory _and_ it automatically
>         casts to any
>         pointer type the caller uses (which is the reason it's used in
>         malloc).
> Ok with me. Oppositions from anyone else?

Committed.

Javier, please remove the unneeded cast.

-- 
Regards,
Pavel Roskin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]