Re: [PATCH] Video mode fixes in linux loader

[Robert Millan]

On Mon, Apr 13, 2009 at 07:20:20PM -0400, Pavel Roskin wrote:
> > We could detect this situation by checking video= parameter, and setting
> > text mode if intelfb is found.  But then again do we want to prevent
> > future versions of intelfb from gracefuly transitioning from vesa mode
> > without screen glitch?
> 
> No, that would be bad.  It's even possible that intelfb would work
> correctly in other configurations.  The laptop has resolution 1440x900
> that doesn't match any VESA mode.

Alright.

> > > Some
> > > kernels may not support VESA modes at all.
> > 
> > I don't think this is applicable;  all modern versions of Linux include
> > vesa modesetting in its 16-bit entry code, and older versions are already
> > detected by the new loader (user is prompted to use linux16).
> 
> I can disable CONFIG_FB, and then the screen remains blank until X
> starts.  It's entirely possible that some distros don't enable CONFIG_FB
> to save memory, and I don't always enable it in the kernels I configure
> myself.

Makes sense for official GRUB.

However, I'd still like to add a macro check that can be enabled on distros
that ship Linux builds with CONFIG_FB and want to enable seamless mode
transition (this will be the case for e.g. Debian).

> > > "vga=ask" is not a warning now.  It causes "error: You need to load the
> > > kernel first", apparently from initrd.  In other words, the "linux"
> > > command fails and there is no visible warning.
> > 
> > Sounds like my error code is wrong, but we could turn it into a warning
> > like you suggested.
> 
> I was editing the command line from the menu, so I  could not see the
> message.  Waiting for input is a fair game for an option that implies
> waiting for input.

Spot on.  Will do that.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."