Re: [PATCH] Use symbol database to maintain module dependence

[Bean]

On Tue, Apr 28, 2009 at 2:13 AM, Vladimir 'phcoder' Serbinenko
<address@hidden> wrote:
> symdb code seems to duplicate your list code. Perhaps you could reuse the
> file from kernel thus making maintaining easier

Hi,

I'm planning to use kern/list.c at first, but there is some issue.
list.c uses grub_strcmp, which means we need to add kern/misc.c as
well. But kern/misc.c uses environment and terminal output, etc. I end
up adding a lot of unrelated stuff just to satisfy the dependence. So
perhaps it'd be better to keep it simple for now.

A better solution is to move the string function to a separate source
file, such as kern/string.c. But this is the subject of another patch.

> I liked the file modsym.lst: it gives clear view of symbols.
> This patch brek grub-install because moddep.lst isn't copied correctly
> Also check that
> Also in some places I saw
> +  while (n)
> +    {
> +      modified += remove_string (&u->cur_mods, (char *) n->name);
> Here perhaps modified = remove_string (..) || modified; is more appropriate
> +      n = n->next;
> +    }
>

Right, the += is a quick trick, || would be more meaningful.

> +  remove MODULES          remove modules from the symbol databsae\n\
> Typo
>

Oh, thanks for noticing this.

> On Mon, Apr 27, 2009 at 8:33 AM, Bean <address@hidden> wrote:
>>
>> Hi,
>>
>> ping ?
>>
>> On Tue, Apr 21, 2009 at 5:11 AM, Bean <address@hidden> wrote:
>> > Hi,
>> >
>> > This patch add a new tool grub-symdb to manage symbol database and
>> > update module dependence as required. The build process is greatly
>> > simplified, moddep.lst, def-*.lst, und-*.lst are not generated
>> > anymore. grub-symdb will read the module files and update modsym.lst
>> > and moddep.lst automatically.
>> >
>> > --
>> > Bean
>> >
>>
>>
>>
>> --
>> Bean
>>
>>
>> _______________________________________________
>> Grub-devel mailing list
>> address@hidden
>> http://lists.gnu.org/mailman/listinfo/grub-devel
>
>
>
> --
> Regards
> Vladimir 'phcoder' Serbinenko
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
>



-- 
Bean