Re: Revision 2136 breaks two-disk configuarion

[David Miller]

From: Pavel Roskin <address@hidden>
Date: Mon, 27 Apr 2009 01:25:37 -0400

> Hello!
> 
> Since the revision 2136, I'm getting a non-fatal error message:
> 
> GRUB loading.
> Welcome to GRUB!
> 
> alloc magic is broken at 0x7fdaf20
> Aborted. Press any key to exit.
> 
> After pressing enter, the menu appears and I can boot from it.  The
> description of the revision is:
> 
>        * disk/fs_uuid.c (grub_fs_uuid_close): Call grub_disk_close()
>        on disk->data.
> 
> The patch looks wrong to me.  There are no calls to grub_disk_open() in
> disk/fs_uuid.c.  Other callers to grub_disk_close() call
> grub_disk_open() as well.

grub_disk_open() isn't used, but a grub_device_open() does occur
during the iterator that has us find the FS_UUID device.  This
happens search_fs_uuid().

If we don't do this, we leave a device reference open and dangling.