Re: grub-fstest build issue in grub2-r2071 +

[John Stanley]

An update: I looked at the change between r2077 and r2104 and it looks 
like the relevant code is util/hostdisk.c; I've attached a patch that 
appears to fix the problem.

John





Hi Again,
Thanks, r2104 builds with --enable-grub-fstest now, but a new problem,
not present in r2101 has surfaced: the command grub-probe now aborts on
my system with xfs filesystems. Therefore, I cannot run grub-install
(even  with  --modules=xfs). With rev's 2101, 2087, 2077, 2071, and 2065
grub-probe ran without error. Here's my hd config:

#device         mount-point     fs type options         dump    fsck
/dev/hda1       swap            swap    defaults        0       0
/dev/hda2       /               xfs     defaults        1       1


and here's the output of grub-probe (r2104):

# grub-probe -v --target=fs --device /dev/hda2
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd1 is 156301488
grub-probe: info: the size of hd1 is 156301488
grub-probe: info: the size of hd1 is 156301488
grub-probe: info: the size of hd1 is 156301488
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd0 is 156301488
grub-probe: info: the size of hd1 is 156301488
grub-probe: info: the size of hd1 is 156301488
grub-probe: info: the size of hd1 is 156301488
grub-probe: info: the size of hd1 is 156301488
grub-probe: info: /dev/hda2 starts from 2056320
grub-probe: info: opening the device hd0
grub-probe: info: the size of hd0 is 156301488
Aborted

thanks again,
John


Pavel Roskin wrote:
> On Mon, 2009-04-13 at 21:06 -0400, John Stanley wrote:
>   
> > Hi all,
> >
> > I have built grub2-r2065 and it works nicely for me so far for linux 
> > boots (love the graphics!!). However, beginning with r2071, I am unable 
> > to build it with the "--enable-grub-fstest" option  due to several 
> > undefined refs:
> >     
>
> It started in r2067.
>
>   
> > To handle this (I'm now building r2101), I add normal/datetime to the 
> > grub-fstest build specs,
> >     
>
> Fixed in subversion.  Thank you!
>
>   


_______________________________________________
Grub-devel mailing list
address@hidden
http://lists.gnu.org/mailman/listinfo/grub-devel

*** grub2-r2104.orig/util/hostdisk.c    2009-04-13 23:06:08.000000000 -0400
--- grub2-r2104/util/hostdisk.c 2009-04-14 04:57:48.736246452 -0400
***************
*** 625,636 ****
    int len = strlen(map[drive].drive);
    char *p;
  
!   if (dos_part >= 0)
!     len += 1 + ((dos_part + 1) / 10);
    if (bsd_part >= 0)
      len += 2;
  
!   p = xmalloc (len);
    sprintf (p, "%s", map[drive].drive);
    
    if (dos_part >= 0)
--- 625,644 ----
    int len = strlen(map[drive].drive);
    char *p;
  
!   if (dos_part >= 0) {
!     // Add in char length of dos_part+1
!     int tmp = dos_part + 1;
!     ++len;
!     while ( (tmp /= 10) ) len++;
!   }
    if (bsd_part >= 0)
      len += 2;
  
!   // Length to alloc is: char length of map[drive].drive, plus
!   //                     char length of (dos_part+1) or of bsd_part, plus
!   //                     2 for the comma and a null/end of string (\0)
!   p = xmalloc (len+2);
! 
    sprintf (p, "%s", map[drive].drive);
    
    if (dos_part >= 0)