[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] add clear screen command
From: |
Manoel Rebelo Abranches |
Subject: |
Re: [PATCH] add clear screen command |
Date: |
Thu, 09 Apr 2009 19:16:02 -0300 |
On Thu, 2009-04-09 at 15:44 +0200, phcoder wrote:
> Carlos Roberto do Nascimento Costa wrote:
> > Hello phcoder. thank you for reviewing this patch.
> You're welcome
> >
> > phcoder wrote:
> >> Perhaps putting it into normal.mod instead of separate module is a good
> >> idea
> >
> > When I did this patch, I was thinking: clear is a command like ls, lspci,
> > reboot, sleep, suspend, halt, exit, etc... so, clear needs to be at
> > commands/
> > dir and follows the same ideas behind other commands.
> >
> > Is there any reason to not follows this idea?
> >
> With your patch the created elf contains much more overhead then code.
> While it isn't really a problem it's still a thing about which some
> thinking is needed
> > Best regards,
> >
>
>
I think this overhead is not very relevant since this module won't go in
the image (created by grub-mkimage). Also it will be consistent with the
other commands and better organized(the halt command is actually very
similar).
--
Best Regards,
Manoel Rebelo Abranches
IBM Linux Technology Center Brazil