[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH]: grub: Fix ieee1275 call block typing.
From: |
Manoel Rebelo Abranches |
Subject: |
Re: [PATCH]: grub: Fix ieee1275 call block typing. |
Date: |
Thu, 09 Apr 2009 18:42:08 -0300 |
At first it seems ok. I'll test it in the weekend ok?
On Thu, 2009-04-09 at 14:05 -0700, David Miller wrote:
> From: David Miller <address@hidden>
> Date: Tue, 07 Apr 2009 17:03:26 -0700 (PDT)
>
> > 2009-04-07 David S. Miller <address@hidden>
> >
> > * disk/ieee1275/nand.c (grub_nand_open): All ieee1275 call arg
> > slots are of type grub_ieee1275_cell_t.
> > (grub_nand_read): Likewise.
> > * kern/ieee1275/ieee1275.c (IEEE1275_PHANDLE_INVALID,
> > IEEE1275_IHANDLE_INVALID): Use grub_ieee1275_cell_t since these
> > macros are used to compare values in arg/ret block of the call.
> > (grub_ieee1275_finddevice, grub_ieee1275_get_property,
> > grub_ieee1275_next_property, grub_ieee1275_get_property_length,
> > grub_ieee1275_instance_to_package, grub_ieee1275_package_to_path,
> > grub_ieee1275_instance_to_path, grub_ieee1275_write,
> > grub_ieee1275_read, grub_ieee1275_seek, grub_ieee1275_peer,
> > grub_ieee1275_child, grub_ieee1275_parent, grub_ieee1275_open,
> > grub_ieee1275_close, grub_ieee1275_set_property,
> > grub_ieee1275_set_color): All ieee1275 call arg slots are of type
> > grub_ieee1275_cell_t.
> > * kern/ieee1275/openfw.c (grub_map): Likewise.
> > * include/grub/ieee1275/ieee1275.h (grub_ieee1275_ihandle_t,
> > grub_ieee1275_phandle_t): Define as grub_unit32_t type.
>
> Ping? I'm touching non-sparc code so at least one review would
> be appreciated before I check this in.
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
--
Best Regards,
Manoel Rebelo Abranches
IBM Linux Technology Center Brazil