Re: [PATCH] parttool

[Pavel Roskin]

On Wed, 2009-04-08 at 11:35 +0200, phcoder wrote:
> Is this what you mean?

Yes.

> +static char helpmsg[] =
> +  "perform COMMANDS on partition.\n"
> +  "Use \"parttool PARTITION help\" for the list "
> +  " of available commands";

Please remove one space after "list".

I've tested the command quickly.  A few notes.

We need a command to list the partition table, as "ls" doesn't show the
partition types.

It would be nice to have some feedback, e.g.
parttool (hd0,1) hidden+
Setting partition type to 0x92

"hidden" should work like "hidden+".  I prefer plus and minus before the
word, not after, but it's a matter of taste.

The "hidden" attribute doesn't apply to all partition types.  There is
no such thing as a hidden Linux swap partition.

"parttool PARTITION" should work like "parttool PARTITION help" or maybe
it should give information about the partition.

Modules for the partition (like "pcpart") should be loaded automatically
for any commands including "help".  If that module is missing and cannot
be loaded, all commands should report is, not just "help".

-- 
Regards,
Pavel Roskin