grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Leak fixes


From: Robert Millan
Subject: Re: Leak fixes
Date: Sun, 22 Mar 2009 14:45:52 +0100
User-agent: Mutt/1.5.18 (2008-05-17)

On Sun, Mar 22, 2009 at 02:09:52PM +0100, phcoder wrote:
>    
> -  grub_disk_cache_invalidate (dev_id, disk_id, sector);
> -  
>    index = grub_disk_cache_get_index (dev_id, disk_id, sector);
>    cache = grub_disk_cache_table + index;
> + 
> +  cache->lock = 1;
> +  grub_free (cache->data);
> +  cache->data = 0;
> +  cache->lock = 0;

Does this imply grub_disk_cache_invalidate() is not working properly?  Can it
be fixed instead?

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."




reply via email to

[Prev in Thread] Current Thread [Next in Thread]