Re: [PATCH] patch to compile grub2 in msys/mingw environment

[Robert Millan]

On Sun, Mar 15, 2009 at 03:27:05AM +0800, Bean wrote:
> Hi,
> 
> There are three issue related to msys/mingw environment.
> 
> 1, no nanosleep in mingw, although, the windows API Sleep support millisecond.
> 
> 2, Use stat on device like //./PHYSICALDRIVE0 would fail. It should
> use utility function grub_util_get_disk_size in read_device_map.
> 
> 3, The ln command in msys can't handle symbol link properly, which
> causes AC_CONFIG_LINKS to fail. This patch add new test
> grub_CHECK_LINK_DIR, which is used to decide whether to call
> AC_CONFIG_LINKS or copy directory itself.
> 
> 2009-03-14  Bean  <address@hidden>
> 
>       * util/hostdisk.c (read_device_map): Use grub_util_get_disk_size to
>       instead of stat in mingw environment.
> 
>       * util/misc.c (grub_millisleep): New function in environment.
> 
>       * aclocal.m4 (grub_CHECK_LINK_DIR): New function.
> 
>       * configure.ac: Use grub_CHECK_LINK_DIR to determine whether to use
>       AC_CONFIG_LINKS.

It seems you defined the mingw32 version of grub_millisleep unconditionally.

Btw, would be nice if you could send patches as inline attachments, without
the base64 encoding.  Then I'd have been able to reply using the patch as
context.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."