[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Patch] Move multiboot helpers out of the kernel
From: |
Robert Millan |
Subject: |
Re: [Patch] Move multiboot helpers out of the kernel |
Date: |
Sat, 14 Mar 2009 15:48:44 +0100 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Sat, Mar 14, 2009 at 12:35:09AM +0100, phcoder wrote:
> Index: conf/i386-ieee1275.rmk
> ===================================================================
> --- conf/i386-ieee1275.rmk (revision 2030)
> +++ conf/i386-ieee1275.rmk (working copy)
> @@ -126,10 +126,12 @@
>
> # For _multiboot.mod.
> _multiboot_mod_SOURCES = loader/ieee1275/multiboot2.c \
> + loader/i386/multiboot_helper.S \
multiboot_helper.S is not being used on i386-ieee1275 AFAICT
> - /* Unload all modules and stop the floppy driver. */
> - call EXT_C(grub_dl_unload_all)
grub_dl_unload_all() just disappeared. Is this intentional? I
tend to agree that grub_dl_unload_all() is a waste of time, but
this should be discussed separately.
> - call EXT_C(grub_stop_floppy)
grub_stop_floppy() was moved to grub_multiboot_boot(). I think
grub_machine_fini() would be the more appropiate place. I'm not
sure why it was in those asm snippets to begin with (does someone
know?).
Also, grub_unix_real_boot() completely disappeared with your patch.
This seems to break *BSD.
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."