grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bugfix] Characters disappearing in gfxterm


From: BandiPat
Subject: Re: [Bugfix] Characters disappearing in gfxterm
Date: Wed, 11 Mar 2009 10:36:40 -0400
User-agent: Thunderbird 2.0.0.19 (X11/20081209)

Vesa Jääskeläinen wrote:
phcoder wrote:
Hello. I've run into the bug that when editing menu entry in gfxterm
characters disappear after cursor moves away from its position. Here is
bugfix

I don't think this is a clean fix:

Index: term/gfxterm.c
===================================================================
--- term/gfxterm.c      (revision 1974)
+++ term/gfxterm.c      (working copy)
@@ -744,6 +744,8 @@
   /* Render cursor to text layer.  */
   grub_video_set_active_render_target (text_layer);
   grub_video_fill_rect (color, x, y, width, height);
+  if (! show)
+    write_char ();
   grub_video_set_active_render_target (GRUB_VIDEO_RENDER_TARGET_DISPLAY);
/* Mark cursor to be redrawn. */

It is not designed to work in there. I think modifying this needs
logical level approach and not ad hoc fix.
=====================

Has there been any further work done on the disappearing characters in gfxterm? I know you guys had looked at it, but the last word was it was not fixed yet. I understand it's not a priority, but a fix would help in me getting the devs for Zenwalk to approve it's use in the next release version.

Also, do you intend to release another stable version soon? As I watch the progress of Grub2, I continue to see a good program get even better, so using svn is fine for me! You've added so much since the 1.96 release though, it just seems another stable release is past due. Continue the great work you're doing though, as good software never truly gets finished!

Thanks,
Pat


--
       ---Zenwalk v6.0--Linux 2.6.28---
        Registered Linux User #225206
"Ever tried Zen computing?"  http://www.zenwalk.org







reply via email to

[Prev in Thread] Current Thread [Next in Thread]