Re: [PATCH] Unify rescue and normal commands

[Bean]

On Sun, Mar 8, 2009 at 9:07 PM, Robert Millan <address@hidden> wrote:
> On Fri, Mar 06, 2009 at 01:40:36AM +0800, Bean wrote:
>> Hi,
>>
>> This patch unify the two command set, make them available in both
>> rescue and normal mode.
>
> Could you provide a bit of insight on what we archieve with this?  I assume
> the idea is that a number of commands no longer need to drag normal.mod in,
> which is useful for size constrained use cases (which ones do you have in
> mind?).
>
> Is there something else to this?  Does normal mode still work the same way?

Hi,

Some reason for unify command set:

1, Some of the normal mode function are just duplication, such as set,
unset, insmod, lsmod, rmmod, boot. And loader commands usually have
two sets, the normal mode part just calls the underlying rescue one,
such as _linux and linux, _chain and chain, _bsd and bsd, etc. These
are eliminated with unify commands.

2, It frees command from normal.mod. The basic command is supported in
kernel, and extended commands only needs extcmd.mod. This make it
possible to embedded some useful command in core.img itself.

3, It's also an important step for my planning of splitting the normal
mode. IMO, it'd be nice to have an unify interface in grub2, users get
different function by loading different modules. For example, to get
rescue mode, he uses minicmd + basic command line + basic line parser,
to get normal mode, he uses menu viewer + bash like parser.

-- 
Bean