[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/7]: Implement proper sparc64 kern startup.
From: |
David Miller |
Subject: |
Re: [PATCH 3/7]: Implement proper sparc64 kern startup. |
Date: |
Wed, 04 Mar 2009 03:42:48 -0800 (PST) |
From: Vesa Jääskeläinen <address@hidden>
Date: Wed, 04 Mar 2009 13:40:20 +0200
> David Miller wrote:
> > This replaces the C implementation with a proper assembler
> > one. Also add missing grub_prefix[] declaration to
> > kernel.h
> >
> > 2009-03-03 David S. Miller <address@hidden>
> >
> > * kern/sparc64/ieee1275/init.c: Delete, replace with...
> > * kern/sparc64/ieee1275/crt0.S: assembler implementation.
> > * include/grub/sparc64/ieee1275/kernel.h: Declare grub_prefix[].
>
> I must say that I am not familiar with sparc. But there were lots of
> functions inside of init.c. Are those all not needed at all?
Nope, things have changed a lot since that file was written
so many years ago. Some of it has moved into generic
ieee1275 code in fact.
> And if this is true. This patch is missing matching .rmk modifications...
See patch 7, it does that and ties everything together.
> Please have a look at other archs how it is done there.
I most certainly did.