grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/7]: Fix sparc64 setjmp implementation.


From: David Miller
Subject: Re: [PATCH 1/7]: Fix sparc64 setjmp implementation.
Date: Wed, 04 Mar 2009 03:05:12 -0800 (PST)

From: Vesa Jääskeläinen <address@hidden>
Date: Wed, 04 Mar 2009 12:59:37 +0200

> David Miller wrote:
> 
> > +   stx     %g1, [%sp + 2047 + (14 * 8)]
> > +        retl
> > +    restore %o1, 0, %o0
> 
> Please check your white spaces. As we can see here those three commands
> are on different columns (mixed tabs and spaces). This applies to every
> other patch you sent too...

I used plain ASCII text for my patch postings.

I just double checked and they are perfectly fine and applyable in my
email client.

Also note that in the delay slot of control transfer instructions, I
do intentionally use TAB then one space, as this is common practice
for sparc assembler to visually denote the delay slot instruction.

Even GCC outputs assembler using this convention :-)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]