Re: Efiemu

[phcoder]

Bean wrote:
> First, I notice some novel use of macro. For example, use GRUB_EFI to
> wrap around efi calls, which expands to different prefix in different
> environment. I'm not a big fan of macro, and this seems a little
> weird.
It can't be done without at least some macros because it's able to load 
64-bit efiemu from 32-bit mode and vice-versa. But GRUB_EFI can be 
replaced to a set of grub_autoefi_* aliases

> Also, perhaps you should just avoid linux_efiemu altogether. The efi
> linux loader contains some tricks that mostly make sense in apple efi
> firmware, and it might cause hazard in bios environment. Besides, if
> it's just for testing purpose, linux is not a very good efi citizen,
> it doesn't even have a efi loader of its own.
I agree that for now this part of patch should probably be left out. At 
least until we merge all i386/*/linux.c to i386/linux.c by using Vesa's 
memory manager and video functions. However efiemu can help linux to get 
decent efi support in future.

--

Regards
Vladimir 'phcoder' Serbinenko