Re: [PATCH] make partition active

[Bean]

On Thu, Feb 12, 2009 at 2:28 AM, phcoder <address@hidden> wrote:
> Pavel Roskin wrote:
>>
>> On Wed, 2009-02-11 at 14:43 +0100, phcoder wrote:
>>>
>>> Here's the patch to add a replacement for old "makeactive" command
>>> New syntax is
>>> activate PARTITION
>>> E.g.
>>> activate hd0,1
>>
>> Is it necessary to change the name?  I think "makeactive" is a better
>> name for what it does.
>
> Actually I don't really care but on http://grub.enbug.org/CommandList it was
> suggested to change the name. But what I dislike is having this command
> without argument which always activates current root partition
>>
>> Maybe we could use a more generic solution, e.g. a command for setting
>> different flags (or "attributes" in GPT terminology), such as bootable,
>> read-only, hidden (that would apply only to some partition types in the
>> PC partition table) and so on.
>
> It's a good possibility but I don't want to encumber the partition module
> with non-essential functions since they're often integrated into core.img.
> But it's possible to have something like
>
> pctool hd0,1 boot+ hidden-
> gpttool hd0,1 ro+
>
> (Actually I find the name "pc" unfortunate, IMO "fdisk" would be much
> better)
> It's also possible to write a wrapper
> parttool hd0,1 boot+
>
> Which chooses the correct tool and launches it (a tool can be easily
> registered as a pair of partition style name and a function). In this case
> we wouldn't even need separate command for different partition style. We
> have however to find a way to list all available flags in
>
> help parttool

Hi,

The patch looks fine to me, except for perhaps the name. activate
doesn't seems to suggest its function. Frankly, makeactive doesn't
make much sense as well, but at least it's already widely used in grub
legacy, old user could easily guess its function by name.

-- 
Bean