Re: USB support merge (Re: [PATCH] (ata.mod) Fix ATAPI protocol)

[Marco Gerards]

Robert Millan <address@hidden> writes:

> On Mon, Jan 19, 2009 at 11:15:41AM +0100, Marco Gerards wrote:
>> Perhaps my USB code might help in some occasions
>> for scsi.c, I am not completely sure if they are in sync.  I sent in
>> the USB code earlier.  This code can be committed, although endianess
>> is not handled correctly at all places.
>
> Hi,
>
> Alright then.  I just checked in your last USB patch, after reviewing it:
>
>   http://lists.gnu.org/archive/html/grub-devel/2008-08/msg00604.html
>
> I agree it's best to commit it.  It has a few minor problems, but this is
> much better than leaving it to bitrot.  Then we can work on fixing them more
> easily.

Thanks, I am happy it is merged now.  It would help if people reported
success/failure with USB support.

> Let's enumerate them again:
>
>   - OHCI works on qemu but hasn't been tested on real hardware.
>
>   - --enable-grub-emu-usb isn't yet known to work.
>
>   - There might be endianess issues affecting powerpc (note: we aren't
>     building it there yet, we'd have to move PCI support to i386.rmk first)

It is even certain :-)

>   - A few parts of it are marked "XXX".
>
> I'll add one more to the list: keyboard support wasn't included in this
> patch.  I'll look into your other pieces of code and retrieve a working
> keyboard driver.

Right, this shouldn't be too hard as the code was there.  But I have
seen you submitted this already.

--
Marco