Re: [PATCH] try to avoid false positives on FAT filesystem

[Robert Millan]

On Sun, Feb 08, 2009 at 08:59:58PM +0100, Felix Zielcke wrote:
> Am Sonntag, den 08.02.2009, 20:56 +0100 schrieb Robert Millan:
> 
> > I reviewed this thread and couldn't find it.  Did you send it elsewhere?
> 
> In my first message where you quoted the changelog entry.
> Well again attached.

Sorry, I must have lost it.

> 2009-02-05  Felix Zielcke  <address@hidden>
> 
>       fs/fat.c (grub_fat_mount): Try to avoid false positives by checking
>       bpb.version_specific.fat12_or_fat16.fstype and
>       bpb.version_specific.fat32.fstype.
> 
> Index: fs/fat.c
> ===================================================================
> --- fs/fat.c  (revision 1973)
> +++ fs/fat.c  (working copy)
> @@ -187,6 +187,11 @@ grub_fat_mount (grub_disk_t disk)
>    if (grub_disk_read (disk, 0, 0, sizeof (bpb), (char *) &bpb))
>      goto fail;
>  
> +  if (! grub_strncmp((const char 
> *)bpb.version_specific.fat12_or_fat16.fstype,"FAT12",5)
> +      || ! grub_strncmp((const char 
> *)bpb.version_specific.fat12_or_fat16.fstype,"FAT16",5)
> +      || ! grub_strncmp((const char 
> *)bpb.version_specific.fat32.fstype,"FAT32",5))
> +    goto fail;
> +  
>    /* Get the sizes of logical sectors and clusters.  */
>    data->logical_sector_bits =
>      fat_log2 (grub_le_to_cpu16 (bpb.bytes_per_sector));

Looks good to me.  But please add spaces between ')' and 'b', and after ','.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."