grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bugfix] Characters disappearing in gfxterm


From: Vesa Jääskeläinen
Subject: Re: [Bugfix] Characters disappearing in gfxterm
Date: Sun, 08 Feb 2009 10:47:34 +0200
User-agent: Thunderbird 2.0.0.19 (Windows/20081209)

phcoder wrote:
> Hello. I've run into the bug that when editing menu entry in gfxterm
> characters disappear after cursor moves away from its position. Here is
> bugfix

I don't think this is a clean fix:

> Index: term/gfxterm.c
> ===================================================================
> --- term/gfxterm.c    (revision 1974)
> +++ term/gfxterm.c    (working copy)
> @@ -744,6 +744,8 @@
>    /* Render cursor to text layer.  */
>    grub_video_set_active_render_target (text_layer);
>    grub_video_fill_rect (color, x, y, width, height);
> +  if (! show)
> +    write_char ();
>    grub_video_set_active_render_target (GRUB_VIDEO_RENDER_TARGET_DISPLAY);
>  
>    /* Mark cursor to be redrawn.  */

It is not designed to work in there. I think modifying this needs
logical level approach and not ad hoc fix.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]