Re: grub-probe detects ext4 wronly as ext2

[Javier Martín]

El sáb, 07-02-2009 a las 20:30 +0100, Felix Zielcke escribió:
> Am Mittwoch, den 04.02.2009, 14:08 +0100 schrieb Javier Martín:
> 
> > Well, I am happy to post a diff of the patch against current SVN head
> > (r1973). I have personally confirmed (in a VM) that it:
> > 1) Still builds (and even runs! ^^)
> > 2) Works with existing ext2/3 file systems (I haven't checked ext4 FSs
> > but the "extents" bit is marked as supported, so it should work)
> > 3) Correctly rejects journal devices, which will then appear as "unknown
> > filesystem" when accessed.
> 
> FLEX_BG needs to be added to the list of ignored flags.
> As Robert already said in his last reply to this thread [0]
> 
> const char *local_error = 0;
> Please use NULL.
> 
>  +    EXT2_DRIVER_MOUNT_FAIL(0);
> 
> I share his opinion that this isn't needed.
> 
> If you fix this and write a changelog then I commit this.
> 
> [0] http://lists.gnu.org/archive/html/grub-devel/2008-08/msg00645.html

Oops... I was going to send a new version of the patch with those fixed,
but when doing a "svn up" so that it would be against HEAD, I've noticed
that Robert has just integrated a much cleaner version without the macro
and local_error thingies. Well, the only thing left to do is adding
flex_bg - here goes the patch. It also clarifies a comment and corrects
those added in my original patch and Robert's cleaned-up version that
don't end with ".  */" as they should.

-- Lazy, Oblivious, Rational Disaster -- Habbit

BTW: Robert, you're having a total mailing spree today! What's it been,
30 posts? Evolution nearly choked, and my spam filter was about to ban
you as "mass mailing - possible spam" ;)

ext2_incompat_flexbg.patch
Description: Text Data

signature.asc
Description: Esta parte del mensaje está firmada digitalmente