Re: Remove trailing space from FAT label

[Robert Millan]

On Wed, Feb 04, 2009 at 01:01:55PM +0100, phcoder wrote:
> Hello. Here is the patch to remove trailing spaces from FAT label. These 
> spaces generally aren't considiered to be part of label
> Thanks
> Vladimir 'phcoder' Serbinenko

> Index: fs/fat.c
> ===================================================================
> --- fs/fat.c  (revision 1973)
> +++ fs/fat.c  (working copy)
> @@ -809,7 +809,13 @@
>  
>        if (dir.attr == GRUB_FAT_ATTR_VOLUME_ID)
>       {
> -       *label = grub_strndup ((char *) dir.name, 11);
> +       int labellen = 0, i;
> +       for (i = 0; i < 11; i++)

Please use a descriptive macro instead of hardcoding 11.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."