[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] caseless uuid detection, fixed wrong behaviour for strncasec
From: |
Pavel Roskin |
Subject: |
Re: [PATCH] caseless uuid detection, fixed wrong behaviour for strncasecmp, added strcasecmp |
Date: |
Tue, 27 Jan 2009 23:02:52 -0500 |
On Tue, 2009-01-27 at 20:49 -0500, Pavel Roskin wrote:
> > > We have a very similar function search_fs_uuid() in disk/fs_uuid.c, and
> > > it still uses grub_strcmp(). Should it be using grub_strcasecmp() as
> > > well? Can we export that function to reuse it in commands/search.c?
P.S. The reuse would be impractical. fs_uuid is a separate module, not
the core. Reusing search_fs_uuid() would make the "search" module
depend on "fs_uuid". In my opinion, it's not worth the trouble to
introduce that dependency. It's not like we would save a lot of code.
--
Regards,
Pavel Roskin
- [PATCH] caseless uuid detection, fixed wrong behaviour for strncasecmp, added strcasecmp, Daniel Mierswa, 2009/01/21
- Re: [PATCH] caseless uuid detection, fixed wrong behaviour for strncasecmp, added strcasecmp, Pavel Roskin, 2009/01/21
- Re: [PATCH] caseless uuid detection, fixed wrong behaviour for strncasecmp, added strcasecmp, Daniel Mierswa, 2009/01/23
- Re: [PATCH] caseless uuid detection, fixed wrong behaviour for strncasecmp, added strcasecmp, Pavel Roskin, 2009/01/26
- Re: [PATCH] caseless uuid detection, fixed wrong behaviour for strncasecmp, added strcasecmp, Daniel Mierswa, 2009/01/26
- Re: [PATCH] caseless uuid detection, fixed wrong behaviour for strncasecmp, added strcasecmp, Pavel Roskin, 2009/01/27
- Re: [PATCH] caseless uuid detection, fixed wrong behaviour for strncasecmp, added strcasecmp,
Pavel Roskin <=
- Re: [PATCH] caseless uuid detection, fixed wrong behaviour for strncasecmp, added strcasecmp, ebik, 2009/01/28