Re: [PATCH] Fix for PXE module

[Alex Smith]

On Thu, Dec 11, 2008 at 3:37 AM, Bean <address@hidden> wrote:
> On Wed, Dec 10, 2008 at 12:23 AM, Alex Smith <address@hidden> wrote:
>> Hi,
>>
>> A while ago I submitted a bug to the GRUB bugtracker with a patch
>> attached to fix the PXE module
>> (https://savannah.gnu.org/bugs/index.php?24661). It doesn't seem to
>> have been noticed so I'm submitting it here too.
>>
>> The PXE TFTP API only allows one open connection at any one time. The
>> PXE module in GRUB2 has code to handle this in some places, but in
>> other places (grub_pxefs_open and grub_pxefs_close) it is not handled,
>> causing errors. For example, when I try to insert the multiboot module
>> from PXE, that wants to insert the _multiboot module, resulting in the
>> PXE call failing because 2 connections are being made.
>>
>> I've attached a patch which handles this properly in grub_pxefs_open()
>> and grub_pxefs_close(). With these changes made I can successfully
>> load GRUB2 from PXE, and boot a kernel.
>
> Hi,
>
> Thanks for the patch. It looks good to me, would you please add the
> changelog entry so that I can commit it to svn ?
>
> --
> Bean
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>

I've attached an updated copy of the patch with a ChangeLog entry.

Thanks,
Alex

grub2-r1933-pxe-fixup.patch
Description: Binary data