Re: [PATCH] GSoC #10 new font engine (UTF-8 support+bugfix)

[Vesa Jääskeläinen]

Colin D Bennett wrote:
> Update: 
> 
> I fixed an error pointed out to me by Y.Volta: 
> In grub_font_get(), if no fonts are loaded, a null pointer is
> dereferenced.  This is fixed in the attached patch.
> 
> The grub_font_get() function now returns a dummy font object (a
> statically allocated font object with no characters) so that callers of
> grub_font_get() can be assured that the return value will never be
> NULL.  If no fonts are loaded, then the "unknown glyph" will be used
> for all characters, but it will be safe.

Hi Colin,

I applied this patch against SVN today and tried it out. And noticed
that gfxterm gets a bit "broken" after this. Was this the thing that I
promised to look at :) ? Or was my merge just incomplete?

Videotest was fine however. (or how fine it can be with just unifont.bdf)

After:
loadfont /boot/grub/unifont.pf2

lsfonts gives:
Loaded fonts:
Unknown -1

Is this expected?

Thanks,
Vesa Jääskeläinen