grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Corrections to affs and sfs


From: Krzysztof Smiechowicz
Subject: Re: [PATCH] Corrections to affs and sfs
Date: Sat, 29 Nov 2008 09:27:51 +0100
User-agent: Thunderbird 2.0.0.18 (X11/20081125)

Hello,

Robert Millan pisze:

Index: fs/sfs.c
===================================================================
--- fs/sfs.c    (revision 1919)
+++ fs/sfs.c    (working copy)
@@ -172,7 +172,8 @@
          return grub_errno;
        }
- for (i = 0; i < grub_be_to_cpu16 (tree->nodes); i++)
+      grub_uint16_t nodescount = grub_be_to_cpu16(tree->nodes);
+      for (i = nodescount - 1; i >= 0; i--)

nodescount is only used once; why adding a variable?

No particular reason. Feel free to correct it :)

Best regards,
Krzysztof




reply via email to

[Prev in Thread] Current Thread [Next in Thread]