grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: __FILE__ (Re: [PATCH] framework for building modules externally)


From: Robert Millan
Subject: Re: __FILE__ (Re: [PATCH] framework for building modules externally)
Date: Fri, 7 Nov 2008 20:02:18 +0100
User-agent: Mutt/1.5.13 (2006-08-11)

On Thu, Nov 06, 2008 at 10:10:56PM +0100, Christian Franke wrote:
> 
> See attached patch for a possible fix: Each module using grub_dprintf 
> (here disk.c) may specify its name in 'this_file'. When all modules are 
> changed, the '#define this_file' and all #undefs can be removed.

This adds redundancy which later makes it more work to move code around and
rename files, etc.  Why not make it part of the build system?  I.e. to build
foo.c, you need gcc -Dfile=foo.c foo.c ?

But then again, since gcc is free software perhaps it'd make more sense to
add new candy there? (e.g. __RELATIVE_FILE__ or so).

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."




reply via email to

[Prev in Thread] Current Thread [Next in Thread]