Re: [PATCH] Move normal, serial & pci to i386.rmk

[Vesa Jääskeläinen]

Robert Millan wrote:
> On Mon, Sep 08, 2008 at 06:17:34PM +0300, Vesa Jääskeläinen wrote:
>> Robert Millan wrote:
>>> On Mon, Sep 08, 2008 at 10:49:02AM -0400, Pavel Roskin wrote:
>>>> Quoting Robert Millan <address@hidden>:
>>>>
>>>>> This patch moves normal, serial and pci to conf/i386.rmk.
>>>> Why i386?  That code is not i386 specific.
>>> It is.  Notice it's being moved from conf/i386-*.rmk, not common.rmk.
>>>
>>> normal:  Includes normal/i386/setjmp.S
>> Should we move this out of normal.mod ?
> 
> You mean as a standalone module, or to kernel?  In a standalone module, we'd
> still want to have that module in i386.rmk?  Then it's basicaly the same
> issue.  And in kernel there's the problem about size...
> 

Or another option is to put all common stuff in common.rmk and then
concatenate platform features in platform specific .rmk.