grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Move normal, serial & pci to i386.rmk


From: Robert Millan
Subject: Re: [PATCH] Move normal, serial & pci to i386.rmk
Date: Mon, 8 Sep 2008 17:09:20 +0200
User-agent: Mutt/1.5.13 (2006-08-11)

On Mon, Sep 08, 2008 at 10:49:02AM -0400, Pavel Roskin wrote:
> Quoting Robert Millan <address@hidden>:
> 
> >
> >This patch moves normal, serial and pci to conf/i386.rmk.
> 
> Why i386?  That code is not i386 specific.

It is.  Notice it's being moved from conf/i386-*.rmk, not common.rmk.

normal:  Includes normal/i386/setjmp.S

serial, pci:  Relies on grub_{in,out}{b,w,l} functions, which are only
  implemented for i386 so far.  Of course, if someone writes the powerpc
  stubs, then they could be moved to common.rmk, but they're i386-specific
  now.

> I believe we could declare SPARC broken, but keep PowerPC working.

Agreed.  I suggest we remove the conf/sparc* files, which are burdensome
(since people unaware that SPARC is broken might try to keep them uptodate)
and don't really provide any hard-to-find knowledge, and keep the
kern/*/sparc/* bits which might be useful if/when someone tries to reinstate
the port.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."




reply via email to

[Prev in Thread] Current Thread [Next in Thread]