grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] GSoC #06 VBE optimization for BGR/BGRA color modes


From: Vesa Jääskeläinen
Subject: Re: [PATCH] GSoC #06 VBE optimization for BGR/BGRA color modes
Date: Sun, 07 Sep 2008 18:59:03 +0300
User-agent: Thunderbird 2.0.0.16 (Windows/20080708)

Colin D Bennett wrote:
> This patch adds optimized routines for video modes using BGR/BGRA color
> format.  Most PC video cards use BGR (24-bit) or BGRA (32-bit) color
> modes, so this is an extremely important change and provides a massive
> performance benefit.
> 
> I also renamed the R8G8B8A8 and R8B8B8 modes to RGBA8888 and RGB888,
> etc., since it began to be highly unreadable when B8G8R8A8 was added
> into the mix.  It seems that having the color components (letters)
> grouped together in the name makes it much easier for me to determine
> the mode name at a glance.

Thanks for the patch. I have committed similar version to SVN.

I made some changes there so apologies if it broke something in between.
I was only able to test it on qemu and it was ok there, but that is far
from complete test. So please test it on real hardware with different
cards and if problems are found report them back.

Thanks,
Vesa Jääskeläinen




reply via email to

[Prev in Thread] Current Thread [Next in Thread]