grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] update configure.ac to autoconf 2.61


From: Pavel Roskin
Subject: Re: [PATCH] update configure.ac to autoconf 2.61
Date: Wed, 03 Sep 2008 19:43:22 -0400

On Wed, 2008-09-03 at 15:27 +0200, Felix Zielcke wrote:
> Attached patch is generated via `autoupdate --force' from autoconf 2.61
> a svn-diff after ./autogen.sh doestn't show anything more, because
> the ./configure script in SVN is already generated with autoconf 2.61.
> 
> autoconf 2.61 is dated 17.11.2006 on ftp.gnu.org
> 
> Debian etch + lenny have autoconf 2.61
> etch has been released 8th April 2007
> Ubuntu has it since feisty which has been released 19th April 2007
> 
> I haven't checked the others but I think this is recent enough for the
> configure.ac (remember it's generated by ./autogen.sh anyway)
> 
> Yes I really want to get rid of old stuff and if you even only need to
> call `autoupdate --force' ;)

I don't see any old stuff being removed.  I don't see any justification
for any of the changes.  The new code is longer and less readable.  I
don't think AC_TRY_COMPILE is a big problem yet.  It's not like it won't
produce a valid test.

In any case, please try to avoid extra long lines where it can be easily
avoided.

Okuji wrote that he uses Autoconf 2.59, so it would be nice to check
that your changes would still work with that version.

-- 
Regards,
Pavel Roskin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]