grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[RFC] Re: [PATCH] new static const char[] channel (was: modname)


From: Felix Zielcke
Subject: [RFC] Re: [PATCH] new static const char[] channel (was: modname)
Date: Tue, 02 Sep 2008 16:05:56 +0200

Am Dienstag, den 02.09.2008, 15:12 +0200 schrieb Felix Zielcke:

> current upstream SVN without my patch
> -rw-r--r-- 1 root root 25153  2. Sep 15:02 /boot/grub/core.img
> and with it
> -rw-r--r-- 1 root root 25220  2. Sep 15:10 /boot/grub/core.img
> 
> So it seems it's getting 67 bytes bigger in my case :(

As now even talked on IRC GCC seems to be able to optimize string
constants already better with directly using them instead of using a
`static const char' for them.
Probable because some strings appear in more then one file.

So in terms of code size better use a macro for this, which would be
then a pure cosmetical change.

Attached is now my previous patch, changed with a bit Search&Replace, so
you all can easily see how it would actually look like.


-- 
Felix Zielcke

Attachment: channel.diff.2
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]